[PATCH] [ELF] Garbage collect unused class

Davide Italiano davide at freebsd.org
Tue Mar 10 15:20:00 PDT 2015


Hi ruiu, shankarke,

 It seems nothing is using it. I plan to add other classes to this file to handl e.g. __init_array_* properly so I would like to remove everything unused first.

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8235

Files:
  lib/ReaderWriter/ELF/Atoms.h

Index: lib/ReaderWriter/ELF/Atoms.h
===================================================================
--- lib/ReaderWriter/ELF/Atoms.h
+++ lib/ReaderWriter/ELF/Atoms.h
@@ -843,36 +843,6 @@
 
   ArrayRef<uint8_t> rawContent() const override { return ArrayRef<uint8_t>(); }
 };
-
-class InitFiniAtom : public SimpleELFDefinedAtom {
-  StringRef _section;
-
-public:
-  InitFiniAtom(const File &f, StringRef secName)
-      : SimpleELFDefinedAtom(f), _section(secName) {}
-
-  Scope scope() const override { return scopeGlobal; }
-
-  SectionChoice sectionChoice() const override { return sectionCustomRequired; }
-
-  StringRef customSectionName() const override { return _section; }
-
-  ContentType contentType() const override { return typeData; }
-
-  uint64_t size() const override { return rawContent().size(); }
-
-  ContentPermissions permissions() const override { return permRW_; }
-
-  Alignment alignment() const override { return size(); }
-
-#ifndef NDEBUG
-  StringRef name() const override { return _name; }
-  std::string _name;
-#else
-  StringRef name() const override { return ""; }
-#endif
-};
-
 } // end namespace elf
 } // end namespace lld

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8235.21648.patch
Type: text/x-patch
Size: 1167 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150310/21f3b4f5/attachment.bin>


More information about the llvm-commits mailing list