[PATCH] Fix makeLibCall arguments for SoftenFloatRes_FRINT function

hfinkel at anl.gov hfinkel at anl.gov
Tue Mar 10 14:04:20 PDT 2015


Regarding the other functions, is there a reason why the obvious modification to the regression test for this one won't work?

Generically, I'd like to see as much testing coverage as possible; when you make the change, I think that it should be done for all of the functions in a consistent manner. Please test as much as you can, but if there are some you can't on your target, that's okay.


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:494
@@ -493,2 +493,3 @@
   SDValue Op = GetSoftenedFloat(N->getOperand(0));
+  bool shouldSignExtend = TLI.shouldSignExtendFloat32InAbiCall();
   return TLI.makeLibCall(DAG, GetFPLibCall(N->getValueType(0),
----------------
Why did you name the callback shouldSignExtendFloat32InAbiCall when the use is not specific to f32? I recommend having the callback take the type, and taking Float32 out of the name.

http://reviews.llvm.org/D7791

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list