[PATCH] [compiler-rt] Turn abort_on_error=1 by default on OS X (part 1/2)

Anna Zaks zaks.anna at gmail.com
Tue Mar 10 11:50:55 PDT 2015


> What about adding a clang driver flag -fsanitize-abort-on-error that will link an extra object?


The only upside I see with this approach is that it will allow us to keep the tests simpler - instead of prepending ASAN_OPTIONS=abort_on_error=0 to the %run expansion, we would need to change the compiler invocation. Plus, we would not need to change the existing tests that set ASAN_OPTIONS directly.

I am not convinced that adding an extra library to a compiler distribution in order to change the default is the right tradeoff here.


http://reviews.llvm.org/D7203

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list