[PATCH] [lld][ELF] Ability to resolve undefined symbols lazily

Rui Ueyama ruiu at google.com
Tue Mar 10 10:42:06 PDT 2015


I didn't request a change to this patch -- I pointed out that the way we usually uses needs to be improved some way. This patch is LGTM. Please submit after addressing other comments.


================
Comment at: include/lld/Core/Simple.h:105
@@ +104,3 @@
+
+  File *find(StringRef sym, bool dataSymbolOnly) override {
+    // For descendants:
----------------
denis-protivensky wrote:
> ruiu wrote:
> > I expect all subclasses need to implement this function, so it's better to not define this here, so that the compiler raises an error if definition is missing.
> I deliberately added it while copying your implementation of virtual archive just because my understanding of Simple group of classes is that they are defaults that can be picked up and used as-is. In general, I agree that this method is excessive for the class. I'd rather say it shouldn't be in the Simple group, but I didn't find better place for it.
Understood.

http://reviews.llvm.org/D8159

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list