[PATCH] [CMake] Don't pass in MSVC warning flags as definitions

[Reid Kleckner]

BTW, this seems like an overall reasonable idea.


================
Comment at: cmake/modules/HandleLLVMOptions.cmake:296
@@ +295,3 @@
+
+  foreach(flag ${msvc_warning_flags})
+    append("${flag}" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
----------------
It might also be faster to string-ify the list like this:
  string(REPLACE ";" " " msvc_warning_flags "${msvc_warning_flags}")

And append that one string to every CMAKE_*_FLAGS var we need to touch.

http://reviews.llvm.org/D8188

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/