[PATCH] [CodeGen] Replace the outgoing chain when reusing stores for extractelt expansion.

hfinkel at anl.gov hfinkel at anl.gov
Mon Mar 9 14:40:21 PDT 2015


LGTM (with simplification mentioned below), thanks for catching this!


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1460
@@ +1459,3 @@
+  // to use the original store's chain as an incoming chain.
+  SmallVector<SDValue, 6> NewLoadOperands;
+  for (size_t i = 0, e = NewLoad->getNumOperands(); i != e; ++i)
----------------
This code can be:
  SmallVector<SDValue, 6> NewLoadOperands(Node->op_begin(), Node->op_end());
  NewLoadOperands[0] = Ch;

http://reviews.llvm.org/D8180

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list