[PATCH] [SCEV] Unify getUnsignedRange and getSignedRange

Sanjoy Das sanjoy at playingwithpointers.com
Mon Mar 9 14:21:32 PDT 2015


On Mon, Mar 9, 2015 at 12:19 PM, Andrew Trick <atrick at apple.com> wrote:
> LGTM assuming I parsed the contorted diff correctly. i.e. there's no functional change except for handling unsigned ranges in more cases.

Yes, the only functional changes are that for add recurrences,
ScalarEvolution::getRange will be more aggressive --
computing the unsigned (resp. signed) range for a SCEVAddRecExpr will
now look at the NSW (resp. NUW) bits and check for signed
(resp. unsigned) overflow.  In some cases (such as the attached test
case) this can be a strict improvement, and should be no worse in all
other cases.

-- Sanjoy


>
>
> http://reviews.llvm.org/D8142
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>



More information about the llvm-commits mailing list