[PATCH] [LAA-memchecks 1/3] Split out NumComparisons checks. NFC

Adam Nemet anemet at apple.com
Mon Mar 9 12:18:59 PDT 2015


================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:1083
@@ -1082,9 +1082,3 @@
 
-  // Check that we did not collect too many pointers or found an unsizeable
-  // pointer.
-  if (!CanDoRT || NumComparisons > RuntimeMemoryCheckThreshold) {
-    PtrRtCheck.reset();
-    CanDoRT = false;
-  }
-
-  if (CanDoRT) {
+  // Check that we did not find an unsizeable pointer.
+  if (CanDoRT)
----------------
hfinkel wrote:
> I know you did not change the terminology here, but I'm not quite sure what 'unsizable pointer' means. Could we say 'unknown dependence' or 'unknown bounds'?
Sure, I think 'unknown bounds' is better.

Thanks very much for the reviews!

http://reviews.llvm.org/D8122

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list