[PATCH] Fix justify error for small structures bigger than 32 bits in fixed arguments for MIPS64 big endian

Daniel Sanders daniel.sanders at imgtec.com
Mon Mar 9 10:27:08 PDT 2015


Thanks. Just a couple things on the test case. At the moment, you're fixing both N32 and N64 but you only test N64. Similarly, we should also test that little endian does the right thing in both cases.


REPOSITORY
  rL LLVM

================
Comment at: test/CodeGen/Mips/cconv/arguments-small-structures-bigger-than-32bits.ll:1
@@ +1,2 @@
+; RUN: llc --march=mips64 -mcpu=mips64r2 < %s | FileCheck %s
+
----------------
Nit: There's normally only one dash on -march=...

================
Comment at: test/CodeGen/Mips/cconv/arguments-small-structures-bigger-than-32bits.ll:1
@@ +1,2 @@
+; RUN: llc --march=mips64 -mcpu=mips64r2 < %s | FileCheck %s
+
----------------
dsanders wrote:
> Nit: There's normally only one dash on -march=...
Could you add RUN lines for the little endian N64 case as well as the big/little-endian N32 cases?

http://reviews.llvm.org/D8174

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list