[PATCH] Clarified the direction rounding occurs in uitofp and sitofp is unspecified

Steve Canon scanon at apple.com
Mon Mar 9 06:14:49 PDT 2015


I'm uncomfortable with this change, as I believe that it makes the llvm conversions incompatible with IEEE-754 conversion (which round according to the dynamic rounding mode unless they're in a (language defined) block with static rounding attribute).

I would much prefer that we say something like "On targets with dynamic rounding modes, [su]itofp rounds according to the dynamic mode.  On targets without dynamic rounding, [su]itofp uses default rounding."


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D6942

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list