[PATCH] [MBP] Don't outline short optional branches

Daniel Jasper djasper at google.com
Mon Mar 9 02:46:10 PDT 2015


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:394
@@ +393,3 @@
+              Pred->size() < OutlineOptionalThreshold)
+            return Pred;
+        }
----------------
chandlerc wrote:
> Shouldn't this be disabling the return of Succ here rather than arbitrarily returning Pred?
> 
> And in general, it seems very strange to look at all of the predecessors' predecessors here. That seems really expensive and it isn't clear why. This at least needs some serious commenting to clarify the algorithm used.
Addressed both concerns.

http://reviews.llvm.org/D8108

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list