[polly] r231593 - Add end user report message for unprofitable regions [NFC]

Tobias Grosser tobias at grosser.es
Mon Mar 9 00:02:04 PDT 2015


On 08.03.2015 17:15, Johannes Doerfert wrote:
> On 03/08, Tobias Grosser wrote:
>> On 08.03.2015 17:00, Johannes Doerfert wrote:
>>> On 03/08, Tobias Grosser wrote:
>>>> On 08.03.2015 16:11, Johannes Doerfert wrote:
>>>>>   ; CHECK: remark: /tmp/test.c:2:3: The following errors keep this region from being a Scop.
>>>>> +; CHECK: remark: /tmp/test.c:2:3: The regions does not seem to be amendable to profitable polyhedral optimization
>>>>
>>>> 'The region' without 's', also
>>> also what?
>>
>> I was thinking of a possibly shorten this to something like:
>>
>> 'No profitable polyhedral optimization found'
> Sure. Go ahead.

r231633

>> but was not sure if this actually might improve readability. What do you
>> think?
> I just want a "real" message because our default user message:
>
>     virtual std::string getEndUserMessage() const {
>       return "Unspecified error.";
>     };
>
> is kinda useless and for this and some other cases no message is given after:
>    remark: LOCATION: The following errors keep this region from being a Scop.
>
>
> I have student groups working on Polly and I think a lot of question could
> be avoided if we allow the user to get more high-level information about
> the detection as well as other steps.

I agree this indeed important. Thanks for pushing forward here.

Tobias





More information about the llvm-commits mailing list