[PATCH] [LAA-memchecks 1/3] Split out NumComparisons checks. NFC

[hfinkel at anl.gov]

LGTM.


================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:1083
@@ -1082,9 +1082,3 @@
 
-  // Check that we did not collect too many pointers or found an unsizeable
-  // pointer.
-  if (!CanDoRT || NumComparisons > RuntimeMemoryCheckThreshold) {
-    PtrRtCheck.reset();
-    CanDoRT = false;
-  }
-
-  if (CanDoRT) {
+  // Check that we did not find an unsizeable pointer.
+  if (CanDoRT)
----------------
I know you did not change the terminology here, but I'm not quite sure what 'unsizable pointer' means. Could we say 'unknown dependence' or 'unknown bounds'?

================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:1127
@@ -1123,12 +1126,3 @@
                                          TheLoop, Strides, true);
-      // Check that we did not collect too many pointers or found an unsizeable
-      // pointer.
-      if (!CanDoRT || NumComparisons > RuntimeMemoryCheckThreshold) {
-        if (!CanDoRT && NumComparisons > 0)
-          emitAnalysis(LoopAccessReport()
-                       << "cannot check memory dependencies at runtime");
-        else
-          emitAnalysis(LoopAccessReport()
-                       << NumComparisons << " exceeds limit of "
-                       << RuntimeMemoryCheckThreshold
-                       << " dependent memory operations checked at runtime");
+      // Check that we didn't find an unsizeable pointer.
+      if (!CanDoRT && NumComparisons > 0) {
----------------
Same comment here about 'unsizable pointer'

http://reviews.llvm.org/D8122

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/