PATCHES: R600/SI: More cleanups for the assembler

Tom Stellard tom at stellard.net
Fri Mar 6 17:56:38 PST 2015


On Fri, Mar 06, 2015 at 03:58:57PM -0800, Matt Arsenault wrote:
> 
> 
> On 03/06/2015 02:26 PM, Tom Stellard wrote:
> > Hi,
> >
> > Here are some more cleanup patches that are required for the assembler.
> >
> > -Tom
> >
> > 0001-R600-SI-Fix-opcode-for-ds_read2_b64-and-ds_read2st64.patch
> >
> >
> >  From 22812d5990ead84354a35fce5f3ac58c487ffaf4 Mon Sep 17 00:00:00 2001
> > From: Tom Stellard<thomas.stellard at amd.com>
> > Date: Fri, 27 Feb 2015 22:21:27 -0500
> > Subject: [PATCH 01/10] R600/SI: Fix opcode for ds_read2_b64 and
> >   ds_read2st64_b64
> >
> > ---
> >   lib/Target/R600/SIInstructions.td | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target/R600/SIInstructions.td
> > index ab1f08f..289f2db 100644
> > --- a/lib/Target/R600/SIInstructions.td
> > +++ b/lib/Target/R600/SIInstructions.td
> > @@ -882,8 +882,8 @@ defm DS_WRITE2ST64_B64 : DS_Store2_Helper <0x0000004F, "ds_write2st64_b64", VReg
> >   
> >   defm DS_READ2_B32 : DS_Load2_Helper <0x00000037, "ds_read2_b32", VReg_64>;
> >   defm DS_READ2ST64_B32 : DS_Load2_Helper <0x00000038, "ds_read2st64_b32", VReg_64>;
> > -defm DS_READ2_B64 : DS_Load2_Helper <0x00000075, "ds_read2_b64", VReg_128>;
> > -defm DS_READ2ST64_B64 : DS_Load2_Helper <0x00000076, "ds_read2st64_b64", VReg_128>;
> > +defm DS_READ2_B64 : DS_Load2_Helper <0x00000077, "ds_read2_b64", VReg_128>;
> > +defm DS_READ2ST64_B64 : DS_Load2_Helper <0x00000078, "ds_read2st64_b64", VReg_128>;
> >   
> >   //===----------------------------------------------------------------------===//
> >   // MUBUF Instructions
> > -- 2.0.4
> My copies of the SI and CI documentation has the old values for these. 
> Is the public documentation wrong?
> 

Table 11.7 lists them as:

DS_READ2_B64 -> 119 (0x75)
DS_READ2ST64_B64 -> 120 (0x76)

The decimal number is correct, the hexadecimal number is wrong.

-Tom



More information about the llvm-commits mailing list