[PATCH] [compiler-rt] Turn abort_on_error=1 by default on OS X (part 1/2)

[Anna Zaks]

> How about altering the default at run-time? 

>  If you someone recognize that you are running via launchd, enable abort_on_error

>  That would sounds reasonable to me.


That'd be confusing to the user. Someone launches the app from the dock, the app crashes. They launch the same app from command line, it does not. Having consistency and generating a crashlog is the most user friendly behavior.

You are right, "not --crash" will slow down testing. I did not think about this right away.

The only other idea I have is to use an altered run command (ex: "%run_under_san" or "%set_asan_options %run") that would include ASAN_OPTIONS in its expansion. All tests would have to adopt it, but it would make tests running under lit and manually behave the same.


http://reviews.llvm.org/D7203

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/