[llvm] r229911 - MC: Allow multiple comma-separated expressions on the .uleb128 directive.

Tom Stellard tom at stellard.net
Fri Mar 6 12:29:09 PST 2015


On Mon, Mar 02, 2015 at 09:55:54AM -0800, Jim Grosbach wrote:
> 
> > On Mar 2, 2015, at 9:35 AM, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:
> > 
> > On Thu, Feb 19, 2015 at 02:07:08PM -0800, Hans Wennborg wrote:
> >> On Thu, Feb 19, 2015 at 1:53 PM, Joerg Sonnenberger
> >> <joerg at britannica.bec.de> wrote:
> >>> On Thu, Feb 19, 2015 at 08:24:05PM -0000, Benjamin Kramer wrote:
> >>>> Author: d0k
> >>>> Date: Thu Feb 19 14:24:04 2015
> >>>> New Revision: 229911
> >>>> 
> >>>> URL: http://llvm.org/viewvc/llvm-project?rev=229911&view=rev
> >>>> Log:
> >>>> MC: Allow multiple comma-separated expressions on the .uleb128 directive.
> >>>> 
> >>>> For compatiblity with GNU as. Binutils documents this as
> >>>> '.uleb128 expressions'. Subtle, isn't it?
> >>> 
> >>> Thanks. Hans, can we get this into 3.6, either pre- or post-3.6.0?
> >>> Slowly going over the build failures for pkgsrc on ARM.
> >> 
> >> This looks like a post-3.6.0 thing to me, which means Tom is in charge.
> > 
> > That's fine with me, so let's bring this up now that we are post-3.6.0
> > :) Jim, any objection?
> 
> SGTM.

LGTM, go ahead and merge this to the 3.6 branch.

-Tom



More information about the llvm-commits mailing list