[PATCH] [compiler-rt] Symbolizer refactoring: Merge common parts of POSIXSymbolizer and WinSymbolizer

[Timur Iskhodzhanov]

================
Comment at: lib/sanitizer_common/sanitizer_symbolizer.cc:98
@@ +97,3 @@
+  if (!FindModuleNameAndOffsetForAddress(addr, &module_name, &module_offset))
+    return res;
+  // Always fill data about module name and offset.
----------------
timurrrr wrote:
> Interesting: is it possible for a PC to not belong to any module, but still be symbolizable by SymbolizerTools?  JITed code maybe?
[you might consider replying using the web interface, otherwise the discussion is a bit hard to follow here]

> Good question. We certainly don't try to do that in the current POSIXSymbolizer
> (for any of the POSIX tools). Do you know if DbgHelp can do this?

I don't know actually, neither do I know if we can use DIA SDK for that...  But I can imagine us adding support for plugin-line symbolizers, e.g. for V8-generated code maybe?

Kostya, Zachary, any ideas?

http://reviews.llvm.org/D8105

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/