[PATCH] [compiler-rt] Symbolizer refactoring: Merge common parts of POSIXSymbolizer and WinSymbolizer

Kuba Brecka kuba.brecka at gmail.com
Fri Mar 6 07:30:53 PST 2015


Part of http://reviews.llvm.org/D7827.  Moves most of the implementation from `POSIXSymbolizer` to the superclass, `Symbolizer`, and reuses that in `WinSymbolizer`.  Removes `Symbolizer::Disable()`, because we're not using it anyway.

Note that the public methods of `Symbolizer` lock the `mu_` mutex, so both the tool's methods *and* the platform-specific virtual methods of `Symbolizer` (such as `FindModuleNameAndOffsetForAddress`) are synchronized.

http://reviews.llvm.org/D8105

Files:
  lib/sanitizer_common/sanitizer_symbolizer.cc
  lib/sanitizer_common/sanitizer_symbolizer.h
  lib/sanitizer_common/sanitizer_symbolizer_internal.h
  lib/sanitizer_common/sanitizer_symbolizer_libcdep.cc
  lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc
  lib/sanitizer_common/sanitizer_symbolizer_win.cc

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8105.21354.patch
Type: text/x-patch
Size: 14560 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150306/bafd79a2/attachment.bin>


More information about the llvm-commits mailing list