[PATCH] [compiler-rt] Symbolizer refactoring: Make WinSymbolizer use SymbolizerTool interface

[Timur Iskhodzhanov]

Looks good to me, thanks!


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_win.cc:21
@@ -20,2 +20,3 @@
 
-#include "sanitizer_symbolizer.h"
+#include "sanitizer_symbolizer_win.h"
+#include "sanitizer_symbolizer_internal.h"
----------------
Please make sure this order of includes passes `ninja SanitizerLintCheck`.
I'm not sure the latter works on Windows, I'm usually doing that on my Linux box before committing.

================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_win.cc:91
@@ +90,3 @@
+
+bool FindModuleNameAndOffsetForAddress(uptr addr, const char **module_name,
+                                       uptr *module_offset) {
----------------
this function should not be placed in the anonymous namespace if is [planned to be] used in other source files.

http://reviews.llvm.org/D8089

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/