[PATCH] tsan: fix signal handling during stop-the-world

[Dmitry Vyukov]

fixed in rev 231457

On Thu, Mar 5, 2015 at 6:10 PM, Sergey Matveev <earthdok at google.com> wrote:
> Still kinda wary about this approach, but let's give it a try. LGTM
>
>
> ================
> Comment at: lib/sanitizer_common/sanitizer_stoptheworld.h:63
> @@ -63,1 +62,3 @@
> +// The callback should not call any libc functions. The callback must not call
> +// exit nor _exit and instead return to the caller.
>  // This function should NOT be called from multiple threads simultaneously.
> ----------------
> nit: could you please be consistent in "function" vs "function()" in comments
>
> ================
> Comment at: lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cc:424
> @@ +423,3 @@
> +    // NOTE: errno is shared between this thread and the tracer thread.
> +    // internal_waitpid may call syscall() which can access/spoil errno,
> +    // so we can't call it now. Instead we for the tracer thread to finish using
> ----------------
> same
>
> http://reviews.llvm.org/D8032
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>