[PATCH] [Patch] Loop Interchange Pass

[hfinkel at anl.gov]

Thanks for continuing to work on this. I have a few minor comments below, but we can move this in-tree. Please go ahead an commit, and we'll continue to iterate/test. When you commit, please commit the change to lib/Analysis/DependenceAnalysis.cpp separately.


REPOSITORY
  rL LLVM

================
Comment at: lib/Transforms/Scalar/LoopInterchange.cpp:515
@@ +514,3 @@
+    }
+#ifdef ENABLE_DEBUGGING
+    DEBUG(dbgs() << "Dependence before inter change \n");
----------------
ENABLE_DEBUGGING is too generic for this. How about calling this:

  DUMP_DEP_MATRICIES


================
Comment at: lib/Transforms/Scalar/LoopInterchange.cpp:547
@@ +546,3 @@
+
+    // TODO: Handle lcssa PHI's.
+    if (containsLCSSAPHI)
----------------
Please make this TODO more specific. What happens now and what should happen instead?

================
Comment at: lib/Transforms/Scalar/LoopInterchange.cpp:688
@@ +687,3 @@
+      if (auto D = DA->depends(Src, Des, true)) {
+        // TODO: Fix his handle only anti/output dep for now.
+        if (D->isFlow()) {
----------------
Please make this more specific. We do handle anti deps. What needs to happen?

http://reviews.llvm.org/D7499

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/