[PATCH] [PM] Create a separate library for high-level pass management code.

[Pete Cooper]

> On Mar 5, 2015, at 2:47 PM, Chandler Carruth <chandlerc at google.com> wrote:
> 
> 
> On Thu, Mar 5, 2015 at 2:46 PM, Pete Cooper <peter_cooper at apple.com <mailto:peter_cooper at apple.com>> wrote:
> Yeah, I agree that layering is an issue.
> 
> The current pass code is in lib/IR, which I think is libCore.  There’s no fundamental reason why your code couldn’t also live there right now.  Its linked against everything you mentioned already.
> 
> Wait, you've lost me.
I’m talking about what if you didn’t create a new library.  I think you’re talking about the relationship between the new libPasses and other libraries.  Otherwise i’m lost too :)

I was saying that if you didn’t create a new library, then I assumed the new PM code could live in libCore next to the current PM code.  And then everything just depends on libCore as they currently do.
> 
> Target depends on Core. Passes depends on Target. So this can't live in Core?
> 
> Same relation ship for Analysis and Transforms?
>  
> 
> Then the question becomes:
> - Is that gross putting the pass manager in there?
> - Will there come a time when you actually want passes and don’t have IR?
> 
> I think if the answer to either of those questions is ‘yes’, then go for it.  Otherwise i’m not opposed to the library (i.e., go for it if no-one else is strongly opposed), but i’m also not seeing a big win either.
> 
> Thanks,
> Pete
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150305/2b5d1f1a/attachment.html>