[PATCH] [ConstantRange] Teach multiply to be cleverer about signed ranges.

[Nick Lewycky]

I got a bounce message ...

On 4 March 2015 at 00:37, Nick Lewycky <nlewycky at google.com> wrote:

> On 4 March 2015 at 00:21, James Molloy <james.molloy at arm.com> wrote:
>
>> Hi Nick,
>>
>> Gentle ping.
>>
>
> Sorry! Phabricator and I are not getting along today.
>
> "This example is a bit off, the min should be `min(-1*-2, -1*2, 3*-2,
> 3*2)` = `-6`.  The code is correct, as far as I can tell."
> Sanjoy's comment about your comment is correct, '4' and '3' are outside
> the half-open range. Please fix!
>
> Besides that, LGTM!
>

See above!


>
>
>>
>> Cheers,
>>
>> James
>>
>>
>> REPOSITORY
>>   rL LLVM
>>
>> http://reviews.llvm.org/D7789
>>
>> EMAIL PREFERENCES
>>   http://reviews.llvm.org/settings/panel/emailpreferences/
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150305/f35cd8a9/attachment.html>