[PATCH] [Windows] Implementing backtracing of self
Zachary Turner
zturner at google.com
Wed Mar 4 22:56:38 PST 2015
Yes that line is dead. I caught it after uploading the patch, but didn't
think it was worth uploading a new patch over. In any case, I'll remove it
before comitting. Thanks!
On Wed, Mar 4, 2015 at 10:32 PM David Majnemer <david.majnemer at gmail.com>
wrote:
> ================
> Comment at: lib/Support/Windows/Signals.inc:15
> @@ -15,2 +14,3 @@
> #include <algorithm>
> +#include <setjmp.h>
> #include <signal.h>
> ----------------
> This is dead now, no?
>
> ================
> Comment at: lib/Support/Windows/Signals.inc:387-388
> @@ +386,4 @@
> +
> + STACKFRAME64 StackFrame = {0};
> + CONTEXT Context = {0};
> + ::RtlCaptureContext(&Context);
> ----------------
> You could simplify this a little bit more if you'd like with:
> STACKFRAME64 StackFrame = {};
> CONTEXT Context = {};
>
> http://reviews.llvm.org/D8068
>
> EMAIL PREFERENCES
> http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150305/a92a4f2e/attachment.html>
More information about the llvm-commits
mailing list