[PATCH] Code Generator Patterns for X86 Gather and Scatter
hfinkel at anl.gov
hfinkel at anl.gov
Wed Mar 4 22:04:18 PST 2015
REPOSITORY
rL LLVM
================
Comment at: ../include/llvm/CodeGen/ISDOpcodes.h:686
@@ -685,1 +685,3 @@
+ // Masked gather and scatter
+ MGATHER, MSCATTER,
----------------
For these nodes (and also the MLOAD/MSTORE nodes above), we need comments explaining what the operands are.
================
Comment at: ../lib/Target/X86/X86InstrInfo.td:723
@@ +722,3 @@
+def vectoraddr : ComplexPattern<iPTR, 5, "SelectAddr", [],[SDNPWantParent]>;
+//def vectoraddr : ComplexPattern<iPTR, 5, "SelectVectorAddr", [],[SDNPWantParent]>;
+
----------------
delena wrote:
> craig.topper wrote:
> > Why is this commented out?
> I don't want to put implementation of SelectVectorAddr() in this patch. I just show that the vectoraddr is a special complex pattern that has its own implementation.
Okay, then the comment should say that.
http://reviews.llvm.org/D7665
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list