[PATCH] Improve CodeGenDAGPattern support with multiple explicit results in an instruction pattern

hfinkel at anl.gov hfinkel at anl.gov
Wed Mar 4 21:59:16 PST 2015


LGTM, thanks!


================
Comment at: utils/TableGen/CodeGenDAGPatterns.cpp:3058
@@ +3057,3 @@
+    for (unsigned i = 0; i != NumResults; ++i) {
+      assert(ResNodes[i]->getNumTypes() == 1 && "FIXME: Unhandled");
+      ResultPattern->setType(i, ResNodes[i]->getExtType(0));
----------------
Please improve the string in this assert to explain what is not handled.

http://reviews.llvm.org/D8073

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list