[llvm] r231351 - Revert "[dsymutil] MSVC does generate move constructors, but it should accept to default them"

Frederic Riss friss at apple.com
Wed Mar 4 21:29:05 PST 2015


Author: friss
Date: Wed Mar  4 23:29:05 2015
New Revision: 231351

URL: http://llvm.org/viewvc/llvm-project?rev=231351&view=rev
Log:
Revert "[dsymutil] MSVC does generate move constructors, but it should accept to default them"

This reverts commit r231350.

It turns out MSVC doesn't generate implicit move constructors and also doesn't accept to default them...
See for example http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc/builds/2786

Modified:
    llvm/trunk/tools/dsymutil/DwarfLinker.cpp

Modified: llvm/trunk/tools/dsymutil/DwarfLinker.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/dsymutil/DwarfLinker.cpp?rev=231351&r1=231350&r2=231351&view=diff
==============================================================================
--- llvm/trunk/tools/dsymutil/DwarfLinker.cpp (original)
+++ llvm/trunk/tools/dsymutil/DwarfLinker.cpp Wed Mar  4 23:29:05 2015
@@ -65,7 +65,10 @@ public:
   }
 
   // Workaround MSVC not supporting implicit move ops
-  CompileUnit(CompileUnit &&RHS) = default;
+  CompileUnit(CompileUnit &&RHS)
+      : OrigUnit(RHS.OrigUnit), Info(std::move(RHS.Info)),
+        CUDie(std::move(RHS.CUDie)), StartOffset(RHS.StartOffset),
+        NextUnitOffset(RHS.NextUnitOffset) {}
 
   DWARFUnit &getOrigUnit() const { return OrigUnit; }
 





More information about the llvm-commits mailing list