[llvm] r231270 - Make DataLayout Non-Optional in the Module

[Alexey Samsonov]

On Wed, Mar 4, 2015 at 1:59 PM, Mehdi Amini <mehdi.amini at apple.com> wrote:

>
> On Mar 4, 2015, at 1:41 PM, Alexey Samsonov <vonosmas at gmail.com> wrote:
>
>
> On Wed, Mar 4, 2015 at 1:02 PM, Mehdi Amini <mehdi.amini at apple.com> wrote:
>
>>
>> > On Mar 4, 2015, at 12:41 PM, H.J. Lu <hjl.tools at gmail.com> wrote:
>> >
>> > I got
>> >
>> > lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:593:  Blank line
>> > at the start of a code block.  Is this needed?
>> > [whitespace/blank_line] [2]
>> >
>> projects/compiler-rt/lib/CMakeFiles/SanitizerLintCheck.dir/build.make:49:
>> > recipe for target
>> > 'projects/compiler-rt/lib/CMakeFiles/SanitizerLintCheck' failed
>> > gmake[6]: *** [projects/compiler-rt/lib/CMakeFiles/SanitizerLintCheck]
>> Error 1
>>
>> Reid fixed it in the meantime.
>>
>> Thanks for reporting it though.
>>
>> How do I run these lint test, I need to get this part of my workflow.
>> I haven’t seen any reference to lint in the programmer manual or the
>> other documentations on llvm.org
>
>
> These failures should no longer be present after r231289.
>
>
>
> Sure, but "ninja check” didn’t catch it locally for me, so I’m still
> interested to know how to reproduce so that I catch it locally before
> breaking a bot next time.
>

I mean, I've removed a check, not fixed the issue (though it was already
done by Reid). This check was a part of "ninja check-all" if compiler-rt
was checked out.



>
> —
> Mehdi
>
>


-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150304/3cae1adb/attachment.html>