[llvm] r230794 - [opaque pointer type] Add textual IR support for explicit type parameter to load instruction

[David Blaikie]

On Mon, Mar 2, 2015 at 2:26 PM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

>
> > On 2015-Feb-27, at 13:18, David Blaikie <dblaikie at gmail.com> wrote:
> >
> > Author: dblaikie
> > Date: Fri Feb 27 15:17:42 2015
> > New Revision: 230794
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=230794&view=rev
> > Log:
> > [opaque pointer type] Add textual IR support for explicit type parameter
> to load instruction
> >
> > Essentially the same as the GEP change in r230786.
> >
> > A similar migration script can be used to update test cases, though a
> few more
> > test case improvements/changes were required this time around:
> (r229269-r229278)
> >
> > import fileinput
> > import sys
> > import re
> >
> > pat = re.compile(r"((?:=|:|^)\s*load (?:atomic )?(?:volatile )?(.*?))(|
> addrspace\(\d+\) *)\*($|
> *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$)")
> >
> > for line in sys.stdin:
> >  sys.stdout.write(re.sub(pat, r"\1, \2\3*\4", line))
> >
> > Reviewers: rafael, dexonsmith, grosser
> >
> > Differential Revision: http://reviews.llvm.org/D7649
> >
> > Added:
> >    llvm/trunk/test/Assembler/invalid-load-mismatched-explicit-type.ll
> >    llvm/trunk/test/Assembler/invalid-load-missing-explicit-type.ll
> > Modified:
>
> I just noticed this didn't update docs/LangRef.rst [1].  Can you
> update it for this and the GEP change?
>

Right right - had a hack at this in r231296 and r231294. Obviously this is
a weird hybrid state, having typed pointers & yet explicitly specifying the
type, but yeah, best the docs reflect the reality at least.


>
> [1]: http://llvm.org/docs/LangRef.html
>
>
> >    llvm/trunk/lib/AsmParser/LLParser.cpp
> >    llvm/trunk/lib/IR/AsmWriter.cpp
> >    llvm/trunk/test/Analysis/BasicAA/2003-02-26-AccessSizeTest.ll
> >    llvm/trunk/test/Analysis/BasicAA/2003-04-22-GEPProblem.ll
> >    llvm/trunk/test/Analysis/BasicAA/2003-05-21-GEP-Problem.ll
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150304/88f636ae/attachment.html>