[PATCH] [compiler-rt] Symbolizer refactoring: Link symbolizer tools into a fallback chain

[Alexey Samsonov]

LGTM, but please address the comment.


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:354
@@ -355,1 +353,3 @@
+   explicit POSIXSymbolizer(IntrusiveList<SymbolizerTool> *tools)
+       : Symbolizer(), tools_(tools) {}
 
----------------
IntrusiveList is designed to be a POD, I think it would be easier to just pass it by value and copy it...

================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:519
@@ -509,3 +518,3 @@
 Symbolizer *Symbolizer::PlatformInit() {
-  return new(symbolizer_allocator_)
-      POSIXSymbolizer(ChooseSymbolizer(&symbolizer_allocator_));
+  IntrusiveList<SymbolizerTool> *list =
+      new (symbolizer_allocator_) IntrusiveList<SymbolizerTool>();
----------------
That is, no need to call to symbolizer_allocator_ here, just
  IntrusiveList<SymbolizerTool> list;
  list.clear();
  //...
  return new(symbolizer_allocator_) POSIXSymbolizer(list);

http://reviews.llvm.org/D8049

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/