[llvm] r231253 - Revert r231132, "Correctly handle -pass-remarks in the gold plugin.", for now, to suppress log floodng in LTO.

[NAKAMURA Takumi]

Author: chapuni
Date: Wed Mar  4 10:24:28 2015
New Revision: 231253

URL: http://llvm.org/viewvc/llvm-project?rev=231253&view=rev
Log:
Revert r231132, "Correctly handle -pass-remarks in the gold plugin.", for now, to suppress log floodng in LTO.

Removed:
    llvm/trunk/test/tools/gold/remarks.ll
Modified:
    llvm/trunk/tools/gold/gold-plugin.cpp

Removed: llvm/trunk/test/tools/gold/remarks.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/gold/remarks.ll?rev=231252&view=auto
==============================================================================
--- llvm/trunk/test/tools/gold/remarks.ll (original)
+++ llvm/trunk/test/tools/gold/remarks.ll (removed)
@@ -1,17 +0,0 @@
-; RUN: llvm-as %s -o %t.o
-
-; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
-; RUN:    -plugin-opt=-pass-remarks=inline %t.o -o %t2.o 2>&1 | FileCheck %s
-
-; CHECK: f inlined into _start
-target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
-target triple = "x86_64-unknown-linux-gnu"
-
-define i32 @f() {
-  ret i32 0
-}
-
-define i32 @_start() {
-  %call = call i32 @f()
-  ret i32 %call
-}

Modified: llvm/trunk/tools/gold/gold-plugin.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/gold/gold-plugin.cpp?rev=231253&r1=231252&r2=231253&view=diff
==============================================================================
--- llvm/trunk/tools/gold/gold-plugin.cpp (original)
+++ llvm/trunk/tools/gold/gold-plugin.cpp Wed Mar  4 10:24:28 2015
@@ -296,9 +296,12 @@ static void diagnosticHandler(const Diag
     Level = LDPL_WARNING;
     break;
   case DS_Note:
-  case DS_Remark:
     Level = LDPL_INFO;
     break;
+    // FIXME: Just ignore remarks for now. They are always passed by
+    // if there is a custom diagnostic handler, so we get flooded.
+  case DS_Remark:
+    return;
   }
   message(Level, "LLVM gold plugin: %s",  ErrStorage.c_str());
 }
@@ -809,7 +812,7 @@ static ld_plugin_status allSymbolsReadHo
     return LDPS_OK;
 
   LLVMContext Context;
-  Context.setDiagnosticHandler(diagnosticHandler, nullptr, false);
+  Context.setDiagnosticHandler(diagnosticHandler);
 
   std::unique_ptr<Module> Combined(new Module("ld-temp.o", Context));
   Linker L(Combined.get());