[llvm] r231224 - Remove explicit RNSuccIterator copy assignment in favor of implicit default

David Blaikie dblaikie at gmail.com
Tue Mar 3 23:51:50 PST 2015


Author: dblaikie
Date: Wed Mar  4 01:51:50 2015
New Revision: 231224

URL: http://llvm.org/viewvc/llvm-project?rev=231224&view=rev
Log:
Remove explicit RNSuccIterator copy assignment in favor of implicit default

Asserting that the source and destination iterators are from the same
region is unnecessary - there's no reason to disallow reassignment from
any regions, so long as they aren't compared.

Modified:
    llvm/trunk/include/llvm/Analysis/RegionIterator.h

Modified: llvm/trunk/include/llvm/Analysis/RegionIterator.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/RegionIterator.h?rev=231224&r1=231223&r2=231224&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Analysis/RegionIterator.h (original)
+++ llvm/trunk/include/llvm/Analysis/RegionIterator.h Wed Mar  4 01:51:50 2015
@@ -145,16 +145,6 @@ public:
     ++*this;
     return tmp;
   }
-
-  inline const Self &operator=(const Self &I) {
-    if (this != &I) {
-      assert(getNode()->getParent() == I.getNode()->getParent()
-             && "Cannot assign iterators of two different regions!");
-      Node = I.Node;
-      BItor = I.BItor;
-    }
-    return *this;
-  }
 };
 
 
@@ -240,16 +230,6 @@ public:
     ++*this;
     return tmp;
   }
-
-  inline const Self &operator=(const Self &I) {
-    if (this != &I) {
-      assert(Node->getParent() == I.Node->getParent()
-             && "Cannot assign iterators to two different regions!");
-      Node = I.Node;
-      Itor = I.Itor;
-    }
-    return *this;
-  }
 };
 
 template<class NodeType, class BlockT, class RegionT>





More information about the llvm-commits mailing list