[PATCH] [compiler-rt] Symbolizer refactoring: Unify access to symbolizer tools from POSIXSymbolizer

Kuba Brecka kuba.brecka at gmail.com
Tue Mar 3 15:26:06 PST 2015


Landed in r231162.

> LGTM. Do you plan to inherit WinSymbolizer from SymbolizerTool?


Yes, although it's not as straight-forward as I'd like. I planned to move the implementation of `POSIXSymbolizer` into just `Symbolizer`, which would no longer have any subclasses. The `ChooseSymbolizer` would then simply have a `if (SANITIZER_WINDOWS)` branch in it, and we wouldn't need `PlatformInit` at all.

Speaking of Windows, I found out that we currently don't run the testcases from the main `TestCases/` directory on Windows (we treat them as if they were in `TestCases/Posix/`), is that intentional?  If yes, what's the point of having a separate `Posix` subdirectory?


http://reviews.llvm.org/D8029

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list