[PATCH] [compiler-rt] Symbolizer refactoring: Unify access to symbolizer tools from POSIXSymbolizer

Kuba Brecka kuba.brecka at gmail.com
Tue Mar 3 13:58:06 PST 2015


In http://reviews.llvm.org/D8029#133837, @samsonov wrote:

> I'm happy with the direction of this change, although:
>
> Note that this does introduce a change in behavior - in case both libbacktrace *and* external symbolizer are available, we could fallback from former to latter. Is there a strong reason for removing this fallback? I originally thought that it can be useful in symbolizers you were going to add.


The initialization of the external symbolizer (in PlatformInit) is wrapped inside `if (!libbacktrace_symbolizer)`, so it doesn't look to me that we currently have such a fallback.  Or am I reading the code wrong?

Anyway, I definitely support having fallbacks, and I plan to submit another patch that implements the chain of symbolizers.


http://reviews.llvm.org/D8029

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list