[llvm] r231126 - Remove ResourcePriorityQueue::dump as it relies on copying a non-copyable type which would result in a double-delete

David Blaikie dblaikie at gmail.com
Tue Mar 3 12:49:05 PST 2015


Author: dblaikie
Date: Tue Mar  3 14:49:05 2015
New Revision: 231126

URL: http://llvm.org/viewvc/llvm-project?rev=231126&view=rev
Log:
Remove ResourcePriorityQueue::dump as it relies on copying a non-copyable type which would result in a double-delete

Modified:
    llvm/trunk/include/llvm/CodeGen/ResourcePriorityQueue.h
    llvm/trunk/lib/CodeGen/SelectionDAG/ResourcePriorityQueue.cpp

Modified: llvm/trunk/include/llvm/CodeGen/ResourcePriorityQueue.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/ResourcePriorityQueue.h?rev=231126&r1=231125&r2=231126&view=diff
==============================================================================
--- llvm/trunk/include/llvm/CodeGen/ResourcePriorityQueue.h (original)
+++ llvm/trunk/include/llvm/CodeGen/ResourcePriorityQueue.h Tue Mar  3 14:49:05 2015
@@ -124,8 +124,6 @@ namespace llvm {
 
     void remove(SUnit *SU) override;
 
-    void dump(ScheduleDAG* DAG) const override;
-
     /// scheduledNode - Main resource tracking point.
     void scheduledNode(SUnit *Node) override;
     bool isResourceAvailable(SUnit *SU);

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/ResourcePriorityQueue.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/ResourcePriorityQueue.cpp?rev=231126&r1=231125&r2=231126&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/ResourcePriorityQueue.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/ResourcePriorityQueue.cpp Tue Mar  3 14:49:05 2015
@@ -637,17 +637,3 @@ void ResourcePriorityQueue::remove(SUnit
 
   Queue.pop_back();
 }
-
-
-#ifdef NDEBUG
-void ResourcePriorityQueue::dump(ScheduleDAG *DAG) const {}
-#else
-void ResourcePriorityQueue::dump(ScheduleDAG *DAG) const {
-  ResourcePriorityQueue q = *this;
-  while (!q.empty()) {
-    SUnit *su = q.pop();
-    dbgs() << "Height " << su->getHeight() << ": ";
-    su->dump(DAG);
-  }
-}
-#endif





More information about the llvm-commits mailing list