[llvm] r231056 - Cleanup after r230934 per Dave's suggestions.
Owen Anderson
resistor at mac.com
Mon Mar 2 21:39:28 PST 2015
Author: resistor
Date: Mon Mar 2 23:39:27 2015
New Revision: 231056
URL: http://llvm.org/viewvc/llvm-project?rev=231056&view=rev
Log:
Cleanup after r230934 per Dave's suggestions.
Modified:
llvm/trunk/lib/AsmParser/LLParser.cpp
llvm/trunk/test/Assembler/getelementptr_invalid_ptr.ll
Modified: llvm/trunk/lib/AsmParser/LLParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/AsmParser/LLParser.cpp?rev=231056&r1=231055&r2=231056&view=diff
==============================================================================
--- llvm/trunk/lib/AsmParser/LLParser.cpp (original)
+++ llvm/trunk/lib/AsmParser/LLParser.cpp Mon Mar 2 23:39:27 2015
@@ -5460,11 +5460,12 @@ int LLParser::ParseGetElementPtr(Instruc
return true;
Type *PtrTy = Ptr->getType();
- if (!isa<SequentialType>(PtrTy))
- return Error(Loc, "pointer type is not valid");
if (VectorType *VT = dyn_cast<VectorType>(PtrTy))
PtrTy = VT->getElementType();
- if (Ty != cast<SequentialType>(PtrTy)->getElementType())
+ SequentialType *SeqPtrTy = dyn_cast<SequentialType>(PtrTy);
+ if (!SeqPtrTy)
+ return Error(Loc, "pointer type is not valid");
+ if (Ty != SeqPtrTy->getElementType())
return Error(ExplicitTypeLoc,
"explicit pointee type doesn't match operand's pointee type");
Modified: llvm/trunk/test/Assembler/getelementptr_invalid_ptr.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Assembler/getelementptr_invalid_ptr.ll?rev=231056&r1=231055&r2=231056&view=diff
==============================================================================
--- llvm/trunk/test/Assembler/getelementptr_invalid_ptr.ll (original)
+++ llvm/trunk/test/Assembler/getelementptr_invalid_ptr.ll Mon Mar 2 23:39:27 2015
@@ -1,5 +1,4 @@
-; RUN: not llvm-as < %s >/dev/null 2> %t
-; RUN: FileCheck %s < %t
+; RUN: not llvm-as < %s 2>&1 | FileCheck %s
; Test the case of an invalid pointer type on a GEP
; CHECK: pointer type is not valid
More information about the llvm-commits
mailing list