[PATCH] During PHI elimination, split critical edges that move copies out of loops

Quentin Colombet qcolombet at apple.com
Mon Mar 2 16:01:04 PST 2015


My concern was this:

>   it currently breaks a few tests


What do you mean by "break"?

>From your last comment, I believe we generate worse code.
If that the case, then just put a flag to preserve the previous behavior and file PR for the regression you find so that we can work on fixing them.
Other than that, the change itself looks good to me.

Thanks,
-Quentin


http://reviews.llvm.org/D8016

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list