[PATCH] [llgo] Disable known failing packages in check-libgo

Andrew Wilkins axwalk at gmail.com
Mon Mar 2 07:10:10 PST 2015


Hi pcc,

There are two packages in libgo which have
known failures when running the "make check" rule.
This change disables those packages in the tests so
that we can run libgo tests without them until the
root causes are identified and resolved.

http://reviews.llvm.org/D8003

Files:
  libgo-check-failures.diff
  third_party/gofrontend/libgo/Makefile.am
  third_party/gofrontend/libgo/Makefile.in
  update_third_party.sh

Index: libgo-check-failures.diff
===================================================================
--- /dev/null
+++ libgo-check-failures.diff
@@ -0,0 +1,40 @@
+diff --git a/libgo/Makefile.am b/libgo/Makefile.am
+index 526b656..31c206e 100644
+--- a/libgo/Makefile.am
++++ b/libgo/Makefile.am
+@@ -3688,7 +3688,6 @@ TEST_PACKAGES = \
+ 	os/check \
+ 	path/check \
+ 	reflect/check \
+-	regexp/check \
+ 	runtime/check \
+ 	sort/check \
+ 	strconv/check \
+@@ -3787,7 +3786,6 @@ TEST_PACKAGES = \
+ 	os/user/check \
+ 	path/filepath/check \
+ 	regexp/syntax/check \
+-	runtime/pprof/check \
+ 	sync/atomic/check \
+ 	text/scanner/check \
+ 	text/tabwriter/check \
+diff --git a/libgo/Makefile.in b/libgo/Makefile.in
+index 2254478..d2482d1 100644
+--- a/libgo/Makefile.in
++++ b/libgo/Makefile.in
+@@ -2193,7 +2193,6 @@ TEST_PACKAGES = \
+ 	os/check \
+ 	path/check \
+ 	reflect/check \
+-	regexp/check \
+ 	runtime/check \
+ 	sort/check \
+ 	strconv/check \
+@@ -2292,7 +2291,6 @@ TEST_PACKAGES = \
+ 	os/user/check \
+ 	path/filepath/check \
+ 	regexp/syntax/check \
+-	runtime/pprof/check \
+ 	sync/atomic/check \
+ 	text/scanner/check \
+ 	text/tabwriter/check \
Index: third_party/gofrontend/libgo/Makefile.am
===================================================================
--- third_party/gofrontend/libgo/Makefile.am
+++ third_party/gofrontend/libgo/Makefile.am
@@ -3688,7 +3688,6 @@
 	os/check \
 	path/check \
 	reflect/check \
-	regexp/check \
 	runtime/check \
 	sort/check \
 	strconv/check \
@@ -3787,7 +3786,6 @@
 	os/user/check \
 	path/filepath/check \
 	regexp/syntax/check \
-	runtime/pprof/check \
 	sync/atomic/check \
 	text/scanner/check \
 	text/tabwriter/check \
Index: third_party/gofrontend/libgo/Makefile.in
===================================================================
--- third_party/gofrontend/libgo/Makefile.in
+++ third_party/gofrontend/libgo/Makefile.in
@@ -2193,7 +2193,6 @@
 	os/check \
 	path/check \
 	reflect/check \
-	regexp/check \
 	runtime/check \
 	sort/check \
 	strconv/check \
@@ -2292,7 +2291,6 @@
 	os/user/check \
 	path/filepath/check \
 	regexp/syntax/check \
-	runtime/pprof/check \
 	sync/atomic/check \
 	text/scanner/check \
 	text/tabwriter/check \
Index: update_third_party.sh
===================================================================
--- update_third_party.sh
+++ update_third_party.sh
@@ -25,6 +25,8 @@
 # Apply a diff that eliminates use of the unnamed struct extension beyond what
 # -fms-extensions supports.
 (cd third_party/gofrontend && patch -p1) < libgo-noext.diff
+# Apply a diff that disables testing of packages known to fail.
+(cd third_party/gofrontend && patch -p1) < libgo-check-failures.diff
 find third_party/gofrontend -name '*.orig' -exec rm \{\} \;
 
 # Remove GPL licensed files.

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8003.21003.patch
Type: text/x-patch
Size: 2781 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150302/a8007433/attachment.bin>


More information about the llvm-commits mailing list