[PATCH] [AArch64] Fix problems in handling generic MSR/MRS instructions
Petr Pavlu
petr.pavlu at arm.com
Mon Mar 2 03:26:20 PST 2015
Updated patch adds a check that the instruction coming in `DecodeSystemPStateInstruction()` is really `MSR (immediate)` (`MSRpstate` in LLVM), which means it can be interpreted as the extended `MSR` if `pstatefield` is not allocated. I think it would be a logical error if the method was called for non-`MSR (immediate)` instructions so the code asserts this condition (instead of returning `Fail`).
The patch also simplifies adding of the general register operand, it is always `XZR`.
http://reviews.llvm.org/D7174
Files:
lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp
test/MC/AArch64/arm64-system-encoding.s
test/MC/AArch64/basic-a64-instructions.s
test/MC/Disassembler/AArch64/basic-a64-instructions.txt
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7174.20995.patch
Type: text/x-patch
Size: 11967 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150302/09e70fcf/attachment.bin>
More information about the llvm-commits
mailing list