[PATCH] RFC: fail-fast iterators for DenseMap

Sanjoy Das sanjoy at playingwithpointers.com
Sat Feb 28 23:46:54 PST 2015


Address Chandler's review.

- no "ADT" in the file or class names.
- changed the vocabulary to "Handle" and "Host"
- suffixed the class names with "Base" and change the DenseMap implementation to use inheritance over composition.
- handled the NDEBUG-only-ness directly in the header file.  Once this was locked down, I could not justify the additional complexity from the template specialization, so I removed that too.


http://reviews.llvm.org/D7931

Files:
  include/llvm/ADT/DenseMap.h
  include/llvm/ADT/EpochTracker.h

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7931.20954.patch
Type: text/x-patch
Size: 8874 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150301/1c04ef77/attachment.bin>


More information about the llvm-commits mailing list