[lld] r230886 - Revert "PECOFF: Temporarily add a lock to un-break buildbot."

Rui Ueyama ruiu at google.com
Sat Feb 28 20:25:05 PST 2015


Author: ruiu
Date: Sat Feb 28 22:25:04 2015
New Revision: 230886

URL: http://llvm.org/viewvc/llvm-project?rev=230886&view=rev
Log:
Revert "PECOFF: Temporarily add a lock to un-break buildbot."

This reverts commit r230086. I added a lock to guard FileCOFF::doParse(),
which killed parallel file parsing. Now the buildbots got back to green,
I believe the threading issue was resolved, so it's time to remove the
guard to see if it works with the buildbots.

Modified:
    lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp

Modified: lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp?rev=230886&r1=230885&r2=230886&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp (original)
+++ lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp Sat Feb 28 22:25:04 2015
@@ -306,10 +306,6 @@ StringRef getMachineName(llvm::COFF::Mac
 }
 
 std::error_code FileCOFF::doParse() {
-  // Acquire a recursive lock because COFF file parsing has side effects.
-  // TODO: remove this lock as soon as possible after fixing threading issue.
-  std::lock_guard<std::recursive_mutex> lock(_ctx.getMutex());
-
   auto binaryOrErr = llvm::object::createBinary(_mb->getMemBufferRef());
   if (std::error_code ec = binaryOrErr.getError())
     return ec;





More information about the llvm-commits mailing list