[PATCH] Add Darwin 13.4 x86_64 builder

Siva Chandra sivachandra at google.com
Fri Feb 27 15:59:05 PST 2015


================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:408
@@ +407,3 @@
+                                      '--options',
+                                      WithProperties('-m --executable %(lldb_bindir)s/lldb --framework %(lldb_bindir)s/LLDB.framework -A x86_64 -C clang -s ../DerivedData/lldb-test-results')],
+                             haltOnFailure=True,
----------------
sivachandra wrote:
> Ah! This should be split into multiple list elements.
Ying explained off list that this set of options are actually form a single argument to '--options'. In which case, a more readable approach is probably:

    comma=['./dosep.py',
           '--options',
           ' '.join(['-m',
                     '--executable', WithProperties('%(lldb_buildir)s/lldb'),
                     '--framework', WithProperties('%(lldb_bindir)s/LLDB.framework'),
                     '-A', 'x86_64', '-C', 'clang',
                     '-s', '../DerivedData/lldb-test-results'])]

But, I leave it up to Ying. Feel free to submit as is.

http://reviews.llvm.org/D7896

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list