[PATCH] [PPC64] Add 64-bit Vector Integer Arithmetic Instructions

Eric Christopher echristo at gmail.com
Fri Feb 27 14:00:16 PST 2015


Couple of inline nit comments. I'll let someone else review the substance.

-eric


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:578
@@ -577,3 +577,3 @@
       // VSX v2i64 only supports non-arithmetic operations.
-      setOperationAction(ISD::ADD, MVT::v2i64, Expand);
-      setOperationAction(ISD::SUB, MVT::v2i64, Expand);
+      if (! Subtarget.hasP8Altivec()) {
+        setOperationAction(ISD::ADD, MVT::v2i64, Expand);
----------------
Whitespace.

================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:6528
@@ +6527,3 @@
+/// Note: The doubleword version of these intrinsics are only valid when
+/// hasP8Altivec is true. However, I'm not sure whether it's worth checking
+/// here for that condition to be true. Since we are dealing with builtins,
----------------
Personally I prefer plain text father than comments with variable names.

http://reviews.llvm.org/D7959

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list