[PATCH] Anonymous namespaces are missing import DW_TAG_imported_module.
Katya Romanova
Katya_Romanova at playstation.sony.com
Fri Feb 27 13:53:41 PST 2015
Hi David,
Yes, these are exactly 4 differences that I wanted to point out.
The questionable differences are #1 and #3.
- GCC doesn't put line/file on a namespace, Clang does. Clang should omit them for brevity
Should I remove generation of line/file names for anonymous namespaces before I commit my change?
--GCC adds line/file on imported_module, Clang doesn't. Clang could add these, I'm not sure if any debugger cares - notionally they could do more accurate expression evaluation with that information (not using the using directive when the user is evaluating an expression in a context lexically prior to the using directive).
Our debugger doesn't care. I'm not sure if other debuggers care. So, I won't do any changes with respect of this.
Is my latest patch look OK or should I change anything?
http://reviews.llvm.org/D7895
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list