[PATCH] Change the fast-isel-abort option from bool to int to enable "levels"

Mehdi AMINI mehdi.amini at apple.com
Fri Feb 27 08:38:09 PST 2015


Hi resistor,

Currently fast-isel-abort will only abort for regular instructions,
and just warn for function calls, terminators, function arguments.
There is already fast-isel-abort-args but nothing for calls and
terminators.

This change turns the fast-isel-abort options into an integer option,
so that multiple levels of strictness can be defined.
This will help no being surprised when the "abort" option indeed does
not abort, and enables the possibility to write test that verifies
that no intrinsics are forgotten by fast-isel.

http://reviews.llvm.org/D7941

Files:
  lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
  test/CodeGen/AArch64/arm64-fast-isel-addr-offset.ll
  test/CodeGen/AArch64/arm64-fast-isel-alloca.ll
  test/CodeGen/AArch64/arm64-fast-isel-br.ll
  test/CodeGen/AArch64/arm64-fast-isel-call.ll
  test/CodeGen/AArch64/arm64-fast-isel-conversion.ll
  test/CodeGen/AArch64/arm64-fast-isel-fcmp.ll
  test/CodeGen/AArch64/arm64-fast-isel-gv.ll
  test/CodeGen/AArch64/arm64-fast-isel-icmp.ll
  test/CodeGen/AArch64/arm64-fast-isel-indirectbr.ll
  test/CodeGen/AArch64/arm64-fast-isel-intrinsic.ll
  test/CodeGen/AArch64/arm64-fast-isel-materialize.ll
  test/CodeGen/AArch64/arm64-fast-isel-rem.ll
  test/CodeGen/AArch64/arm64-fast-isel-ret.ll
  test/CodeGen/AArch64/arm64-fast-isel-store.ll
  test/CodeGen/AArch64/arm64-fast-isel.ll
  test/CodeGen/AArch64/arm64-patchpoint.ll
  test/CodeGen/AArch64/arm64-stackmap.ll
  test/CodeGen/AArch64/arm64-xaluo.ll
  test/CodeGen/AArch64/fast-isel-addressing-modes.ll
  test/CodeGen/AArch64/fast-isel-branch-cond-split.ll
  test/CodeGen/AArch64/fast-isel-branch_weights.ll
  test/CodeGen/AArch64/fast-isel-call-return.ll
  test/CodeGen/AArch64/fast-isel-cbz.ll
  test/CodeGen/AArch64/fast-isel-cmp-branch.ll
  test/CodeGen/AArch64/fast-isel-folding.ll
  test/CodeGen/AArch64/fast-isel-gep.ll
  test/CodeGen/AArch64/fast-isel-int-ext.ll
  test/CodeGen/AArch64/fast-isel-int-ext2.ll
  test/CodeGen/AArch64/fast-isel-int-ext4.ll
  test/CodeGen/AArch64/fast-isel-logic-op.ll
  test/CodeGen/AArch64/fast-isel-memcpy.ll
  test/CodeGen/AArch64/fast-isel-mul.ll
  test/CodeGen/AArch64/fast-isel-runtime-libcall.ll
  test/CodeGen/AArch64/fast-isel-sdiv.ll
  test/CodeGen/AArch64/fast-isel-select.ll
  test/CodeGen/AArch64/fast-isel-shift.ll
  test/CodeGen/AArch64/fast-isel-sqrt.ll
  test/CodeGen/AArch64/fast-isel-tbz.ll
  test/CodeGen/AArch64/fast-isel-trunc.ll
  test/CodeGen/AArch64/fast-isel-vector-arithmetic.ll
  test/CodeGen/AArch64/fast-isel-vret.ll
  test/CodeGen/AArch64/fpimm.ll
  test/CodeGen/AArch64/frameaddr.ll
  test/CodeGen/ARM/fast-isel-GEP-coalesce.ll
  test/CodeGen/ARM/fast-isel-align.ll
  test/CodeGen/ARM/fast-isel-binary.ll
  test/CodeGen/ARM/fast-isel-br-const.ll
  test/CodeGen/ARM/fast-isel-br-phi.ll
  test/CodeGen/ARM/fast-isel-call-multi-reg-return.ll
  test/CodeGen/ARM/fast-isel-call.ll
  test/CodeGen/ARM/fast-isel-cmp-imm.ll
  test/CodeGen/ARM/fast-isel-conversion.ll
  test/CodeGen/ARM/fast-isel-crash.ll
  test/CodeGen/ARM/fast-isel-deadcode.ll
  test/CodeGen/ARM/fast-isel-ext.ll
  test/CodeGen/ARM/fast-isel-fold.ll
  test/CodeGen/ARM/fast-isel-frameaddr.ll
  test/CodeGen/ARM/fast-isel-icmp.ll
  test/CodeGen/ARM/fast-isel-indirectbr.ll
  test/CodeGen/ARM/fast-isel-intrinsic.ll
  test/CodeGen/ARM/fast-isel-ldr-str-arm.ll
  test/CodeGen/ARM/fast-isel-ldr-str-thumb-neg-index.ll
  test/CodeGen/ARM/fast-isel-ldrh-strh-arm.ll
  test/CodeGen/ARM/fast-isel-load-store-verify.ll
  test/CodeGen/ARM/fast-isel-mvn.ll
  test/CodeGen/ARM/fast-isel-pic.ll
  test/CodeGen/ARM/fast-isel-redefinition.ll
  test/CodeGen/ARM/fast-isel-ret.ll
  test/CodeGen/ARM/fast-isel-select.ll
  test/CodeGen/ARM/fast-isel-shifter.ll
  test/CodeGen/ARM/fast-isel-static.ll
  test/CodeGen/ARM/fast-isel-vararg.ll
  test/CodeGen/ARM/fast-isel.ll
  test/CodeGen/Mips/Fast-ISel/br1.ll
  test/CodeGen/Mips/Fast-ISel/callabi.ll
  test/CodeGen/Mips/Fast-ISel/fpcmpa.ll
  test/CodeGen/Mips/Fast-ISel/fpext.ll
  test/CodeGen/Mips/Fast-ISel/fpintconv.ll
  test/CodeGen/Mips/Fast-ISel/fptrunc.ll
  test/CodeGen/Mips/Fast-ISel/icmpa.ll
  test/CodeGen/Mips/Fast-ISel/loadstore2.ll
  test/CodeGen/Mips/Fast-ISel/loadstoreconv.ll
  test/CodeGen/Mips/Fast-ISel/loadstrconst.ll
  test/CodeGen/Mips/Fast-ISel/nullvoid.ll
  test/CodeGen/Mips/Fast-ISel/overflt.ll
  test/CodeGen/Mips/Fast-ISel/retabi.ll
  test/CodeGen/Mips/Fast-ISel/simplestore.ll
  test/CodeGen/Mips/Fast-ISel/simplestorefp1.ll
  test/CodeGen/Mips/Fast-ISel/simplestorei.ll
  test/CodeGen/PowerPC/fast-isel-GEP-coalesce.ll
  test/CodeGen/PowerPC/fast-isel-binary.ll
  test/CodeGen/PowerPC/fast-isel-br-const.ll
  test/CodeGen/PowerPC/fast-isel-call.ll
  test/CodeGen/PowerPC/fast-isel-cmp-imm.ll
  test/CodeGen/PowerPC/fast-isel-const.ll
  test/CodeGen/PowerPC/fast-isel-conversion-p5.ll
  test/CodeGen/PowerPC/fast-isel-conversion.ll
  test/CodeGen/PowerPC/fast-isel-crash.ll
  test/CodeGen/PowerPC/fast-isel-ext.ll
  test/CodeGen/PowerPC/fast-isel-fold.ll
  test/CodeGen/PowerPC/fast-isel-indirectbr.ll
  test/CodeGen/PowerPC/fast-isel-load-store.ll
  test/CodeGen/PowerPC/fast-isel-redefinition.ll
  test/CodeGen/PowerPC/fast-isel-ret.ll
  test/CodeGen/PowerPC/fast-isel-shifter.ll
  test/CodeGen/PowerPC/ppc64-fastcc-fast-isel.ll
  test/CodeGen/PowerPC/ppc64-patchpoint.ll
  test/CodeGen/Thumb2/large-call.ll
  test/CodeGen/X86/fast-isel-args-fail2.ll
  test/CodeGen/X86/fast-isel-args.ll
  test/CodeGen/X86/fast-isel-branch_weights.ll
  test/CodeGen/X86/fast-isel-call.ll
  test/CodeGen/X86/fast-isel-cmp-branch2.ll
  test/CodeGen/X86/fast-isel-cmp-branch3.ll
  test/CodeGen/X86/fast-isel-cmp.ll
  test/CodeGen/X86/fast-isel-divrem-x86-64.ll
  test/CodeGen/X86/fast-isel-divrem.ll
  test/CodeGen/X86/fast-isel-double-half-convertion.ll
  test/CodeGen/X86/fast-isel-extract.ll
  test/CodeGen/X86/fast-isel-float-half-convertion.ll
  test/CodeGen/X86/fast-isel-fneg.ll
  test/CodeGen/X86/fast-isel-fold-mem.ll
  test/CodeGen/X86/fast-isel-fptrunc-fpext.ll
  test/CodeGen/X86/fast-isel-i1.ll
  test/CodeGen/X86/fast-isel-int-float-conversion.ll
  test/CodeGen/X86/fast-isel-ret-ext.ll
  test/CodeGen/X86/fast-isel-select-cmov.ll
  test/CodeGen/X86/fast-isel-select-cmov2.ll
  test/CodeGen/X86/fast-isel-select-pseudo-cmov.ll
  test/CodeGen/X86/fast-isel-select-sse.ll
  test/CodeGen/X86/fast-isel-sse12-fptoint.ll
  test/CodeGen/X86/fast-isel-store.ll
  test/CodeGen/X86/fast-isel-x32.ll
  test/CodeGen/X86/fast-isel-x86-64.ll
  test/CodeGen/X86/fast-isel.ll
  test/CodeGen/X86/frameaddr.ll
  test/CodeGen/X86/patchpoint-webkit_jscc.ll
  test/CodeGen/X86/patchpoint.ll
  test/CodeGen/X86/sqrt.ll
  test/CodeGen/X86/stackmap-fast-isel.ll
  test/CodeGen/X86/tailcall-fastisel.ll
  test/CodeGen/X86/xaluo.ll
  test/MC/ARM/data-in-code.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7941.20856.patch
Type: text/x-patch
Size: 122970 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150227/f6998076/attachment.bin>


More information about the llvm-commits mailing list