[PATCH] Add a lock() function in PassRegistry to speed up multi-thread synchronization.

Mehdi AMINI mehdi.amini at apple.com
Fri Feb 27 07:51:22 PST 2015


================
Comment at: lib/IR/PassRegistry.cpp:52
@@ +51,3 @@
+  if (needMutex)
+    Lock.unlock_shared();
+  return PI;
----------------
It is unfortunate to lose RAII, is there a good reason why SmartScopedReader cannot take an extra parameter to be constructed without locking? (like std::unique_lock())

http://reviews.llvm.org/D7787

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list