[PATCH] Implement variable-sized alloca instrumentation (take 2).

Yury Gribov tetra2005 at gmail.com
Fri Feb 27 01:33:07 PST 2015


> While you don't know the number of allocas, their total size is limited by the size of the stack,

>  so you can pre-allocate an array at the thread start up.

>  dynamically growing array in a hot spot in asan is not wise.


Right, that's why we originally proposed lists. Wouldn't this be much simpler?

> So, maybe we simply use the existing fake stack (in use-after-return mode, or maybe even by default?) to simulate dynamic alloca?


I'd oppose to that - fake stacks pose unacceptable RAM overheads for mobile devices.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7098

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list