[lld] r230728 - Use read{le,be}{16,32}. NFC.

Rui Ueyama ruiu at google.com
Thu Feb 26 20:21:40 PST 2015


Author: ruiu
Date: Thu Feb 26 22:21:40 2015
New Revision: 230728

URL: http://llvm.org/viewvc/llvm-project?rev=230728&view=rev
Log:
Use read{le,be}{16,32}. NFC.

Modified:
    lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileBinaryUtils.h

Modified: lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileBinaryUtils.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileBinaryUtils.h?rev=230728&r1=230727&r2=230728&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileBinaryUtils.h (original)
+++ lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileBinaryUtils.h Thu Feb 26 22:21:40 2015
@@ -9,11 +9,11 @@
 
 
 #include "MachONormalizedFile.h"
+#include "lld/Core/Endian.h"
 #include "lld/Core/Error.h"
 #include "lld/Core/LLVM.h"
 #include "llvm/ADT/StringRef.h"
 #include "llvm/Support/Casting.h"
-#include "llvm/Support/Endian.h"
 #include "llvm/Support/ErrorHandling.h"
 #include "llvm/Support/Host.h"
 #include "llvm/Support/MachO.h"
@@ -28,60 +28,46 @@ namespace normalized {
 
 using llvm::sys::getSwappedBytes;
 
- using llvm::support::ubig16_t;
- using llvm::support::ubig32_t;
- using llvm::support::ubig64_t;
-
- using llvm::support::ulittle16_t;
- using llvm::support::ulittle32_t;
- using llvm::support::ulittle64_t;
-
 template<typename T>
 static inline uint16_t read16(const T *loc, bool isBig) {
   assert((uint64_t)loc % llvm::alignOf<T>() == 0 &&
          "invalid pointer alignment");
-  if (isBig)
-    return *(const ubig16_t *)loc;
-  return *(const ulittle16_t *)loc;
+  return isBig ? read16be(loc) : read16le(loc);
 }
 
 template<typename T>
 static inline uint32_t read32(const T *loc, bool isBig) {
   assert((uint64_t)loc % llvm::alignOf<T>() == 0 &&
          "invalid pointer alignment");
-  if (isBig)
-    return *(const ubig32_t *)loc;
-  return *(const ulittle32_t *)loc;
+  return isBig ? read32be(loc) : read32le(loc);
 }
 
 template<typename T>
 static inline uint64_t read64(const T *loc, bool isBig) {
   assert((uint64_t)loc % llvm::alignOf<T>() == 0 &&
          "invalid pointer alignment");
-  if (isBig)
-    return *(const ubig64_t *)loc;
-  return *(const ulittle64_t *)loc;
+  return isBig ? read64be(loc) : read64le(loc);
 }
 
 inline void write16(uint8_t *loc, uint16_t value, bool isBig) {
   if (isBig)
-    *(ubig16_t *)loc = value;
+    write16be(loc, value);
   else
-    *(ulittle16_t *)loc = value;
+    write16le(loc, value);
 }
 
 inline void write32(uint8_t *loc, uint32_t value, bool isBig) {
   if (isBig)
-    *(ubig32_t *)loc = value;
+    write32be(loc, value);
   else
-    *(ulittle32_t *)loc = value;
+    write32le(loc, value);
 }
 
 inline void write64(uint8_t *loc, uint64_t value, bool isBig) {
   if (isBig)
-    *(ubig64_t *)loc = value;
+    write64be(loc, value);
   else
-    *(ulittle64_t *)loc = value;
+    write64le(loc, value);
 }
 
 inline uint32_t





More information about the llvm-commits mailing list