[llvm] r225562 - Use the DiagnosticHandler to print diagnostics when reading bitcode.

[Duncan P. N. Exon Smith]

> On 2015 Feb 26, at 09:52, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> 
>> Any non-trivial output from `clang-3.5 -gline-tables-only -flto` should
>> cause ToT gold-plugin to crash if this stripping isn't in place, but
>> I'm not sure who uses gold-plugin in production (or what the
>> assumptions are around it) so maybe it's not too important right now.
>> 
> 
> You are right:
> http://llvm.org/bugs/show_bug.cgi?id=22713
> 
> I guess the only reasonable solution is for the plugin to call
> UpgradeDebugInfo, no?

I think so.

> There is no point in doing it during claim_file
> since we are just looking for symbols and without a call to
> Materialize the bitcode reader doesn't know if we are already in
> all_symbols_read or not.

Yes, I agree.

> I will give that a try.