[PATCH] [ELF][X86_64] Handle R_X86_64_PC64 relocation

Sean Silva chisophugis at gmail.com
Thu Feb 26 15:58:05 PST 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.cpp:64
@@ +63,3 @@
+      result |
+      (uint64_t) * reinterpret_cast<llvm::support::ulittle64_t *>(location);
+}
----------------
davide wrote:
> ruiu wrote:
> > Not sure if clang-format formatted like this, but I think there should be no space around "*".
> Ditto. No, it did not, I tried to be consistent to what was already there.
Can you just use endian::read and endian::write functions?

http://reviews.llvm.org/D7820

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list